<html>
<head><meta charset="utf-8"><title>perf run requests · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.20run.20requests.html">perf run requests</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="216813744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf%20run%20requests/near/216813744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.20run.20requests.html#216813744">(Nov 15 2020 at 20:52)</a>:</h4>
<p>A new perf run was requested for <a href="https://github.com/rust-lang/rust/issues/78928">#78928</a>. Is it fine if I just queue it?</p>



<a name="216814010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf%20run%20requests/near/216814010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.20run.20requests.html#216814010">(Nov 15 2020 at 20:57)</a>:</h4>
<p>think so <span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span></p>



<a name="216814150"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf%20run%20requests/near/216814150" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.20run.20requests.html#216814150">(Nov 15 2020 at 21:00)</a>:</h4>
<p>Thanks, done.</p>



<a name="216826691"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf%20run%20requests/near/216826691" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.20run.20requests.html#216826691">(Nov 16 2020 at 02:13)</a>:</h4>
<p>It is generally fine to queue perf requests for PRs -- you might want to check queue (<a href="https://perf.rust-lang.org/status.html">https://perf.rust-lang.org/status.html</a>) but due to CI problems and release week it's been pretty empty, so generally not a problem to queue things in.</p>
<p>The other thing to check is that the PR isn't doing anything weird with CI configs or whatever (like trying to leak secrets or so) but this is a very quick check usually, can just scroll through the diff. (This should be done before any bors try).</p>



<a name="216837127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf%20run%20requests/near/216837127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.20run.20requests.html#216837127">(Nov 16 2020 at 06:41)</a>:</h4>
<p>Ok, thanks.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>